Github user mikezaccardo commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/782#issuecomment-126772880
  
    **This is not yet working properly!**
    
    Stopping and starting the `DynamicCluster` of slaves fails.  When testing 
on `localhost`, a `LocalhostMachineProvisioningLocation` is created (with an ID 
value we'll call X) upon the first time that the cluster is started.  I then 
invoke the "stop" effector in the Brooklyn GUI which stops the master and slave 
cluster.  I then invoke "start" in the GUI, select "localhost" when prompted 
for a location, and the slave cluster fails to start.  This occurs because 
another `LocalhostMachineProvisioningLocation` is created with a new ID (we'll 
call Y).  `DynamicClusterImpl` line 262 attempts to add this new location to 
the `locations` parent member variable.  `addLocation()` checks to see if the 
supplied location already exists, but since the ID of the new localhost 
location does not match the old one (X != Y), it is added to `locations`.  When 
the location to deploy to is attempted to be retrieved on `DynamicClusterImpl` 
line  264, an exception is thrown because more than one location n
 ow exists.
    
    @aledsage @neykov or anyone else, do you have any thoughts about how to fix 
this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to