Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/763#discussion_r36009256
--- Diff:
software/base/src/main/java/brooklyn/entity/software/MachineLifecycleEffectorTasks.java
---
@@ -155,29 +155,42 @@ public void attachLifecycleEffectors(Entity entity) {
.build();
}
+ /** @see {@link #newStartEffector()} */
+ public Effector<Void> newSuspendEffector() {
+ return Effectors.effector(Void.class, "suspend")
+ .description("Suspend the process/service represented by
an entity")
+ .parameter(StopSoftwareParameters.STOP_PROCESS_MODE)
+ .parameter(StopSoftwareParameters.STOP_MACHINE_MODE)
+ .impl(newSuspendEffectorTask())
+ .build();
+ }
+
/**
- * Returns the {@link TaskFactory} which supplies the implementation
for the start effector.
+ * Returns the {@link EffectorBody} which supplies the implementation
for the start effector.
* <p>
* Calls {@link #start(Collection)} in this class.
*/
public EffectorBody<Void> newStartEffectorTask() {
- return new EffectorBody<Void>() {
- @Override
- public Void call(ConfigBag parameters) {
- Collection<? extends Location> locations = null;
+ return new StartEffectorBody();
--- End diff --
I think both re-introducing the effector anonymous classes (in inaccessible
methods) or reverting is a valid way to go.
The effect should be quite limited (I'd say non-existent) because users
have to explicitly re-configure the key with a `LifecycleEffectorTasks`
instance. Using it as a default value doesn't get it serialized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
