Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/810#issuecomment-130092400
@aledsage good question. There are a few answers, but the most relevant one
is that it makes the package rename more time consuming and error prone. Last
week right after the catalog rename in api, I started to work on the location
and the tools were of no help because of the circular dependencies and all.
There are way to many files to make adjustments manually and we want to get
over this part fast.
We agree on the jars being checked in. Although I mentioned karaf, it has
little to do with it, although I think we can get started on that next week
after finishing the package rename. The biggest problem is actually the
circular dependency in core, but there is a simple (possibly temporary)
solution, to move the few tests depending on these jars outside the core (say
in utils/test-core or something) and re-enable them.
In the original mail that started this work you (@aledsage) correctly
stated that we should keep the tests running at all times, otherwise
stabilizing the code will be a nightmare and we should err on the side of
speed. This is indeed cutting a short corner.
I will merge this (I ran the tests again and they pass) just to unblock my
refactoring of ./api, but if you prefer I can move and re-enable the tests, or
even revert this patch if you think it's a bad idea. The alternative is to
rebuild the test jars all the time, which is unpleasant in another way. It's
all about choices. I don't have a particular preference but I thought this is
faster and aligned with the near future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
