Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/792#issuecomment-131799478
Thanks @ygy
I have a few concerns with these changes:
* The behaviour of `PostgreSqlNode` is now different from that of all other
`SoftwareProcess` entities. We should strive for consistency - particularly for
the semantics of the operations/attributes, and for the default behaviours.
* The PostgreSQL `STOP_MACHINE_MODE ` default is changed to NEVER. However,
that means when an app is terminated (recursively calling `stop` on the
entities within it), the VM will be left running (with all references to that
VM being removed).
* The PostgreSQL "install" phase now does more than just install the
software. It feels to me like the execution of `initdb` is part of customising
the install.
For the last point (difference between install, customize and launch), this
is particularly important for entities written to work well on localhost for
integration tests - for many entities you could have multiple instances running
simultaneously, or you could configure + launch a new test instance without it
being affected by previous runs (assuming you hadn't changed version numbers
etc).
This difference becomes more vague as we move to installing things in
conventional places (e.g. `/opt/apache-tomcat-8.0.24`, rather than
`~/brooklyn-managed-processes/...`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
