Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/906#discussion_r39970328
--- Diff:
software/base/src/test/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessStreamsTest.java
---
@@ -105,8 +105,8 @@ protected String getStreamOrFail(Task<?> task, String
streamType) {
String stdin = getStreamOrFail(subTask,
BrooklynTaskTags.STREAM_STDIN);
String stdout = getStreamOrFail(subTask,
BrooklynTaskTags.STREAM_STDOUT);
String stderr = getStreamOrFail(subTask,
BrooklynTaskTags.STREAM_STDERR);
- String env = getStreamOrFail(subTask,
BrooklynTaskTags.STREAM_ENV);
- String msg = "stdin="+stdin+"; stdout="+stdout+";
stderr="+stderr+"; env="+env;
+// String env = getStreamOrFail(subTask,
BrooklynTaskTags.STREAM_ENV);
--- End diff --
I strongly dislike commented out that has no comment to say why it's
commented out and why it might be useful in the future (versus it being
deleted).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
