Hi Justin-
You are right about Spry Media IP -- I can find no indication that the
IP of plugins is properly granted. Same for the inclusion of slideto in
Swagger. They are all very small so I have essentially rewritten them
giving credit to the original in our code -- I think this means we are
cleaner from an IP perspective as the copyright and license now lie with
us but appreciate any feedback you have.
With jquery.wiggle I call it out separately noting that the version we
get is the one bundled with swagger.
With requirejs/text.js both are subprojects of RequireJS so I label our
dependency as on the project with explicit reference to the both the
files require.js and text.js, coming from http://requirejs.org/. With
r.js I treat it slightly differently as it comes from a single repo and
it is a different version. Where r.js includes code fragments from other
projects I've called out all the copyright holders and the license under
that code was included.
Thank you for your review. I think our IP and attribution is much
better for it. If you have any further advice let me know.
The PR is at [1] and the resulting license files delta at [2].
Best
Alex
[1] https://github.com/apache/incubator-brooklyn/pull/923
[2]
https://github.com/ahgittin/incubator-brooklyn/commit/c9d6751885100450d6f047fa3df539d256d5bba5
On 15/09/2015 23:38, Justin Mclean wrote:
Hi,
Your files [2]-[5] are covered as part of distributions of packages we already
credit.
You may want to double check, but these are relatively minor issues as
everything is permissive here.
While both data tables and data tables extensions are MIT licensed they are
different products and may have different copyright owners. [1] You also notice
the years are different in the MIT licenses [2][3]. I don’t know for instance
how IP is handled by Spry Media with the plug ins, (for instance) do they get
plug in contributors to sign ICLAs?
Query wiggle has this header:
/*
jQuery Wiggle
Author: WonderGroup, Jordan Thomas
URL: http://labs.wondergroup.com/demos/mini-ui/index.html
License: MIT (http://en.wikipedia.org/wiki/MIT_License)
*/
Only Swagger UI is mentioned in the LICENSE file. I can see it's a separate
project here [4].
Similar issue with text the LICENSE has require.js (some owners as text) but
iit’s a separate project here [5]. You licence includes the URLs so may be good
to add that.
As for the structure of our LICENSE we wanted it to be it clear from the start
that there are multiple parts to the file.
No issue with it and up to you if you want to change it or not. Just that it's
different format to other Apache projects so took more time to review.
Thanks,
Justin
1. http://www.datatables.net/plug-ins/api/fnStandingRedraw
2. https://github.com/DataTables/DataTables/blob/master/license.txt
3. https://github.com/DataTables/Plugins/blob/master/License.txt
4. https://github.com/jordanthomas/jquery-wiggle
5. https://github.com/requirejs/text
--
Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
This e-mail message is confidential and for use by the addressee only. If
the message is received by anyone other than the addressee, please return
the message to the sender by replying to it and then delete the message
from your computer. Internet e-mails are not necessarily secure. Cloudsoft
Corporation Limited does not accept responsibility for changes made to this
message after it was sent.
Whilst all reasonable care has been taken to avoid the transmission of
viruses, it is the responsibility of the recipient to ensure that the
onward transmission, opening or use of this message and any attachments
will not adversely affect its systems or data. No responsibility is
accepted by Cloudsoft Corporation Limited in this regard and the recipient
should carry out such virus and other checks as it considers appropriate.
