[
https://issues.apache.org/jira/browse/BROOKLYN-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943202#comment-14943202
]
ASF GitHub Bot commented on BROOKLYN-166:
-----------------------------------------
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/865#discussion_r41129553
--- Diff:
usage/jsgui/src/main/webapp/assets/js/view/application-add-wizard.js ---
@@ -180,14 +183,13 @@ define([
}
// finish from config step, preview step, and from first step
if yaml tab selected (and valid)
- var finishVisible = (this.currentStep >= 1)
- var finishEnabled = finishVisible
+ var finishVisible = (this.currentStep >= 1);
+ var finishEnabled = finishVisible;
if (!finishEnabled && this.currentStep==0) {
if (this.model.mode == "yaml") {
// should do better validation than non-empty
finishVisible = true;
- var yaml_code = this.$("#yaml_code").val()
- if (yaml_code) {
+ if (self.editor && self.editor &&
self.editor.getValue()) {
--- End diff --
Second `self.editor` is not necessary.
> Use a feature rich yaml editor
> ------------------------------
>
> Key: BROOKLYN-166
> URL: https://issues.apache.org/jira/browse/BROOKLYN-166
> Project: Brooklyn
> Issue Type: Improvement
> Reporter: Hadrian Zbarcea
> Fix For: 0.8.0
>
>
> Brooklyn would benefit from a feature rich editor that would give a user more
> feedback on what is possible when editing a camp blueprint.
> The best candidate is imho codemirror, used by many apps, including swagger.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
