Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/949#discussion_r42109133
  
    --- Diff: 
usage/jsgui/src/main/webapp/assets/js/view/application-add-wizard.js ---
    @@ -85,6 +85,13 @@ define([
             if (entity.config && _.size(entity.config)) 
result["brooklyn.config"] = entity.config;
             return result;
         }
    +    function getConvertedConfigValue(value) {
    +        try {
    +            return $.parseJSON(value);
    +        } catch (e) {
    +            return value;
    --- End diff --
    
    Theoretically a user could've declared his config key as String only to be 
able to use UI provided values, while treating it as an object under the hood. 
I wasn't able to find such cases though.
    
    To be more robust you could check the key type and convert only if != enum, 
string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to