Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42872387
  
    --- Diff: 
api/src/main/java/org/apache/brooklyn/api/objs/BrooklynObject.java ---
    @@ -141,4 +149,11 @@
              */
             boolean unsubscribe(SubscriptionHandle handle);
         }
    +    
    +    public interface RelationSupport<T extends BrooklynObject> {
    +        public <U extends BrooklynObject> void add(Relationship<? super 
T,U> relationship, U target);
    --- End diff --
    
    Should we add `? super U` for the `Relationship`, for the same reason we 
have it for the `T`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to