Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#issuecomment-158996965
there are merge conflicts that have to be resolved. personally i'd like to
see the code improved before merging; if that means improving test assertion
messages that seems to fit, it's not so large that it's worth the overhead of
doing as a separate PR, but if you prefer to do a separate PR i'm happy to
merge this once the conflicts are resolved. and pls just put in a code comment
such as:
// TODO assertions below should use TestFrameworkAssertions but that
class needs to be improved to give better error messages
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
