kevinis commented on a change in pull request #878: Use prebuilt MesaLink package in travis CI URL: https://github.com/apache/incubator-brpc/pull/878#discussion_r311662413
########## File path: .travis.yml ########## @@ -11,8 +11,10 @@ env: - PURPOSE=unittest - PURPOSE=compile-with-cmake - PURPOSE=compile-with-bazel -#- PURPOSE=compile USE_MESALINK=yes -#- PURPOSE=unittest USE_MESALINK=yes +- PURPOSE=compile USE_MESALINK=yes +- PURPOSE=unittest USE_MESALINK=yes +- PURPOSE=compile-with-cmake USE_MESALINK=yes +- PURPOSE=compile-with-bazel USE_MESALINK=yes Review comment: I have the same feeling; orthogonal build options bloat CI tasks. I'm not familiar with the options other than USE_MESALINK; and it seems irrelevant to this PR which only adddresses a previous MesaLink build issue. So maybe we merge this PR first; and create a new issue/PR for the proposed compile-with-all-options PURPOSE. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
