[GitHub] [incubator-brpc] tinnfu opened a new issue #885: TimerThread::Task::run_and_delete运行到'already unscheduled'分支问题

[GitBox]

tinnfu opened a new issue #885: TimerThread::Task::run_and_delete运行到'already 
unscheduled'分支问题
URL: https://github.com/apache/incubator-brpc/issues/885
 
 
   **Describe the bug (描述bug)**
   
   
![image](https://user-images.githubusercontent.com/8357128/62914695-f8aefa00-bdc3-11e9-84d5-1b8fbbd6c88d.png)
   
   走到"already unscheduled"分支的判断条件，是否应该用 
this->version，而不是"expected_version"。这个函数里的局部变量 expected_version应该始终等于id_version 
吧
   
   看到TimerThread::unschedule，其实改了task->version
   
   **To Reproduce (复现方法)**
   代码阅读
   
   **Expected behavior (期望行为)**
   
   
   **Versions (各种版本)**
   OS:
   Compiler:
   brpc: master分支
   protobuf:
   
   **Additional context/screenshots (更多上下文/截图)**
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org