chenzhangyi commented on a change in pull request #940: multi-level menu in 
builtin service page
URL: https://github.com/apache/incubator-brpc/pull/940#discussion_r334268125
 
 

 ##########
 File path: src/brpc/builtin/tabbed.h
 ##########
 @@ -85,5 +99,13 @@ class Tabbed {
 
 } // namespace brpc
 
+namespace std {
+template<>
+struct less<const brpc::TabInfo *> {
 
 Review comment:
   如果只是sort的话,就不要去做specialize了,这样会break默认按地址排序的用法.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to