jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r359138143
##########
File path: src/brpc/redis_command.cpp
##########
@@ -360,4 +360,87 @@ butil::Status RedisCommandByComponents(butil::IOBuf*
output,
return butil::Status::OK();
}
+RedisCommandParser::RedisCommandParser() {
+ Reset();
+}
+
+ParseError RedisCommandParser::Consume(butil::IOBuf& buf,
+ std::unique_ptr<const char*[]>* commands,
+ int* len_out, butil::Arena* arena) {
Review comment:
这种带长度的数组，除非有特殊的分配方式，否则建议用vector。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
