zyearn commented on a change in pull request #1003: limit minimum value of
max_concurrency for auto_cl
URL: https://github.com/apache/incubator-brpc/pull/1003#discussion_r361894578
##########
File path: src/brpc/policy/auto_concurrency_limiter.cpp
##########
@@ -247,6 +253,7 @@ void AutoConcurrencyLimiter::UpdateMaxConcurrency(int64_t
sampling_time_us) {
_min_latency_us * _ema_max_qps / 1000000 * (1 + _explore_ratio);
}
+ next_max_concurrency = std::max(bthread::FLAGS_bthread_concurrency,
next_max_concurrency);
if (next_max_concurrency != _max_concurrency) {
_max_concurrency = next_max_concurrency;
}
Review comment:
这个文件的186行 _max_concurrency /= 2; 会出现_max_concurrency == 0么
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
