zyearn commented on a change in pull request #1005: ignore ELIMIT for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/1005#discussion_r362364866
########## File path: src/brpc/circuit_breaker.cpp ########## @@ -14,13 +14,22 @@ // // Authors: Lei He ([email protected]) +#include "brpc/circuit_breaker.h" + #include <cmath> +#include <set> +#include <mutex> #include <gflags/gflags.h> -#include <butil/time.h> -#include "brpc/circuit_breaker.h" + +#include "butil/strings/string_number_conversions.h" +#include "butil/strings/string_split.h" +#include "butil/time.h" namespace brpc { +DEFINE_string(circuit_breaker_ignored_error_codes, "2004", Review comment: 如果某些错误码是一定要ignore的，可以写死在代码里，以防止用户在flags里漏加了 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
