jamesge commented on issue #1028: support unix socket
URL: https://github.com/apache/incubator-brpc/pull/1028#issuecomment-575974717
 
 
   Thanks for your contribution. However, the support for unix sockets are 
better encapsulated in EndPoint without changing too much other code, 
especially the Channel. Another limit is that EndPoints are widely used and 
adding a char array inside it is unacceptable. Since valid port is between [0, 
65535], it's possible that we put a pointer inside EndPoint without changing 
the structure size.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to