zyearn commented on issue #1032: replace_include_with_find_package URL: https://github.com/apache/incubator-brpc/pull/1032#issuecomment-576091247 according to https://github.com/apache/incubator-brpc/issues/1023, find_package provide more options for user to set(such as CMAKE_PREFIX_PATH). The minimum cmake version that brpc use is [2.8.10](https://cmake.org/cmake/help/v2.8.10/cmake.html#command:find_package), and find_package is supported in this version. It is safe to replace include with find_package.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
