jamesge commented on a change in pull request #1132:
URL: https://github.com/apache/incubator-brpc/pull/1132#discussion_r436526561
##########
File path: test/CMakeLists.txt
##########
@@ -58,8 +58,11 @@ use_cxx11()
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
#required by butil/crc32.cc to boost performance for 10x
- if(NOT (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.4))
+ if((CMAKE_SYSTEM_PROCESSOR MATCHES "(x86)|(X86)|(amd64)|(AMD64)") AND NOT
(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.4))
Review comment:
这个判断层次需要改进下：要么第一层都是判cpu，要么都是判compiler版本，加上and/or很容易错漏。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
