serverglen commented on a change in pull request #1252:
URL: https://github.com/apache/incubator-brpc/pull/1252#discussion_r514689873
##########
File path: src/bvar/default_variables.cpp
##########
@@ -592,9 +592,8 @@ class DiskStatReader {
struct ReadSelfCmdline {
std::string content;
ReadSelfCmdline() {
- char buf[1024];
- const ssize_t nr = butil::ReadCommandLine(buf, sizeof(buf), true);
- content.append(buf, nr);
+ std::string cmdline= butil::ReadCommandLine(true);
Review comment:
> 给content直接赋值就行了吧
这些问题都改完了，辛苦在帮review下，还需要重新触发下持续集成...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
