wasphin commented on a change in pull request #1320:
URL: https://github.com/apache/incubator-brpc/pull/1320#discussion_r553103053
##########
File path: test/brpc_naming_service_unittest.cpp
##########
@@ -579,6 +579,14 @@ class DiscoveryNamingServiceImpl : public
test::DiscoveryNamingService {
google::protobuf::Closure* done) {
brpc::ClosureGuard done_guard(done);
brpc::Controller* cntl = static_cast<brpc::Controller*>(cntl_base);
+ auto body = cntl->request_attachment().to_string();
+ for (brpc::QuerySplitter sp(body); sp; ++sp) {
+ if (!sp.key().empty()) {
Review comment:
Thanks for the review, and done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
