Huixxi commented on a change in pull request #1478:
URL: https://github.com/apache/incubator-brpc/pull/1478#discussion_r674529725
##########
File path: src/bvar/variable.h
##########
@@ -228,6 +228,11 @@ class Variable {
// RPCTest -> rpctest
// HELLO -> hello
void to_underscored_name(std::string* out, const butil::StringPiece& name);
+// no normalization
+void no_name_normalization(std::string* out, const base::StringPiece& name);
Review comment:
这个函数的目的是提供一个不做归一化的函数，同时不影响原有的默认归一化逻辑，如果用户想保留原始bvar名字，则直接使用该函数替换默认的to_underscored_name函数，请问对于该函数的命名有什么好的建议么？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
