zyearn commented on a change in pull request #1505:
URL: https://github.com/apache/incubator-brpc/pull/1505#discussion_r684490642
##########
File path: src/brpc/rtmp.cpp
##########
@@ -177,6 +185,8 @@ FlvReader::FlvReader(butil::IOBuf* buf)
: _read_header(false), _buf(buf) {
}
+static char g_flv_header[9] = { 'F', 'L', 'V', 0x01, 0x05, 0, 0, 0, 0x09 };
+
Review comment:
这个g_flv_header是不是可以删除了？下面sizeof的部分可以直接填9，然后在注释里把9的由来（flv header）写清楚就可以了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
