v1siuol commented on pull request #1536:
URL: https://github.com/apache/incubator-brpc/pull/1536#issuecomment-902416363


   I take a snippet of this change and test it in git1.8, which looks good to 
me.
   ```
   [root@a2d83421c3b6 abstract_data_type]# git --version
   git version 1.8.3.1
   [root@a2d83421c3b6 abstract_data_type]# committer_date=($(git log -1 
--format="%ci" 2> /dev/null))
   [root@a2d83421c3b6 abstract_data_type]# 
committer_date="${committer_date[0]}T${committer_date[1]}${committer_date[2]:0:3}:${committer_date[2]:3:2}"
   [root@a2d83421c3b6 abstract_data_type]# echo $committer_date
   2020-10-19T12:03:03-04:00
   ```
   
   And it won't break git2.x after the change.
   ```
   $ ./tools/get_brpc_revision.sh .
   0.9.7\|fix_get_brpc_revision\|74db116c\|2021-08-17T21:28:24+02:00
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to