Huixxi commented on a change in pull request #1571:
URL: https://github.com/apache/incubator-brpc/pull/1571#discussion_r727646284
##########
File path: src/brpc/load_balancer.cpp
##########
@@ -24,6 +24,7 @@
namespace brpc {
DEFINE_bool(show_lb_in_vars, false, "Describe LoadBalancers in vars");
+DEFINE_bool(wlb_policy_degradation, false, "Weighted LoadBalancers policy
degradation");
Review comment:
> default_weight_of_wlb，表示默认权重值，默认0，如果大于0，表示开启默认权重值。 这样默认权重的大小可以由用户设定
意思是把wlb_policy_degradation替换为default_weight_of_wlb，默认0，同时代表不开启策略降级，若大于0则代表用户开启了策略降级，并且同时也设定了默认的权重大小对吧。
##########
File path: src/brpc/load_balancer.cpp
##########
@@ -24,6 +24,7 @@
namespace brpc {
DEFINE_bool(show_lb_in_vars, false, "Describe LoadBalancers in vars");
+DEFINE_bool(wlb_policy_degradation, false, "Weighted LoadBalancers policy
degradation");
Review comment:
有的，因为没有设置权重值的机器是不会加到机器列表当中的，也就无法提供服务，这样提供一个默认值，对与那些没有配置权重的机器也会得到一个默认的权值，从而也会被添加到服务机器列表中，wr/wrr的策略也就相应降级到了r/rr策略。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
