yanjianglu commented on a change in pull request #1599:
URL: https://github.com/apache/incubator-brpc/pull/1599#discussion_r745384487
##########
File path: src/brpc/policy/http2_rpc_protocol.cpp
##########
@@ -204,7 +204,7 @@ bool ParseH2Settings(H2Settings* out,
butil::IOBufBytesIterator& it, size_t n) {
default:
// An endpoint that receives a SETTINGS frame with any unknown or
// unsupported identifier MUST ignore that setting (section 6.5.2)
- LOG(WARNING) << "Unknown setting, id=" << id << " value=" << value;
+ // LOG(WARNING) << "Unknown setting, id=" << id << " value=" <<
value;
Review comment:
也可以！需要我直接删除吗？
##########
File path: src/brpc/policy/http2_rpc_protocol.cpp
##########
@@ -204,7 +204,7 @@ bool ParseH2Settings(H2Settings* out,
butil::IOBufBytesIterator& it, size_t n) {
default:
// An endpoint that receives a SETTINGS frame with any unknown or
// unsupported identifier MUST ignore that setting (section 6.5.2)
- LOG(WARNING) << "Unknown setting, id=" << id << " value=" << value;
+ // LOG(WARNING) << "Unknown setting, id=" << id << " value=" <<
value;
Review comment:
已经删除了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
