wwbmmm commented on a change in pull request #1657:
URL: https://github.com/apache/incubator-brpc/pull/1657#discussion_r776231259



##########
File path: src/brpc/protocol.cpp
##########
@@ -203,7 +203,7 @@ BUTIL_FORCE_INLINE bool ParsePbFromZeroCopyStreamInlined(
     // According to source code of pb, SetTotalBytesLimit is not a simple set,
     // avoid calling the function when the limit is definitely unreached.
     if (PB_TOTAL_BYETS_LIMITS < FLAGS_max_body_size) {
-        decoder.SetTotalBytesLimit(INT_MAX, -1);

Review comment:
       You can check protobuf version and keep compatibility with old version 
protobuf
   
   #if GOOGLE_PROTOBUF_VERSION >= 3006000
           decoder.SetTotalBytesLimit(INT_MAX);
   #else
           decoder.SetTotalBytesLimit(INT_MAX, -1);
   #endif




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to