ehds opened a new pull request #1680: URL: https://github.com/apache/incubator-brpc/pull/1680
*Ptotocol Rule*: Ptotocol in client-side is fixed except `baidu_std`, because of `streaming_rpc` need create by `baidu_std`. ptotocol. But in current implementation， there is a chance that client will accept message but not match current protocol. Case: Client issue two RPC names `A` (use `hulu` protocol) and `B`(use` baidu_std` protocol) to server in the same connection, If A is sent before B, client will set preferred protocol to `baidu_std`, server will accept these two request and response. Then if response of B received by client before A, B will be parsed success, because it is matched with current protocol(`baidu_std`). When parse response of A by current preferred ptotocol `baidu_std` will failed, according to *Ptotocol Rule*, client think this response is `streaming_rpc`, and try other ptotocols, then response of B will be parsed ok. That's the point: Shall we just retry `streaming_rpc` when parse failed if current protocol is `baidu_std`? instead of trying all other protocols, or other ptotocol mixed with `baidu_std` will accepted successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
