x2c3z4 commented on a change in pull request #1667:
URL: https://github.com/apache/incubator-brpc/pull/1667#discussion_r790419591
##########
File path: CMakeLists.txt
##########
@@ -25,6 +25,8 @@ option(WITH_DEBUG_SYMBOLS "With debug symbols" ON)
option(WITH_THRIFT "With thrift framed protocol supported" OFF)
option(BUILD_UNIT_TESTS "Whether to build unit tests" OFF)
option(DOWNLOAD_GTEST "Download and build a fresh copy of googletest. Requires
Internet access." ON)
+option(BUILD_TOOLS "Whether to build tools" ON)
+option(WITH_SHARED_LIB "With dynamic lib" ON)
Review comment:
> Maybe it is better to be: option(BUILD_SHARED_LIB "Whether to build
shared lib" ON)
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
