x2c3z4 commented on a change in pull request #1669:
URL: https://github.com/apache/incubator-brpc/pull/1669#discussion_r790420377
##########
File path: src/brpc/redis.h
##########
@@ -107,21 +107,21 @@ class RedisRequest : public ::google::protobuf::Message {
bool SerializeTo(butil::IOBuf* buf) const;
// Protobuf methods.
- RedisRequest* New() const;
- void CopyFrom(const ::google::protobuf::Message& from);
- void MergeFrom(const ::google::protobuf::Message& from);
+ RedisRequest* New() const override;
Review comment:
Look like the redis.h is included by some very common header, and my
project includes the "redis.h" indirectly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
