wwbmmm opened a new pull request #1708: URL: https://github.com/apache/incubator-brpc/pull/1708
LatencyRecorder里面的qps，get_window_recorder_qps 函数里面，static_cast<RecorderWindow*>(arg)->get_span(1, &s); get_span的windows是1的，这样有个问题，如果10s中采集一次，前5s的qps=1000，后5s的qps=0，那么得到的qps就是0。 另外就是get_span的window>1时，会出现qps可能取到小数，比如0.1，然后返回类型就是int64_t，这样就强转成0了，导致没数据。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
