x2c3z4 commented on a change in pull request #1728:
URL: https://github.com/apache/incubator-brpc/pull/1728#discussion_r836310821



##########
File path: src/bvar/collector.cpp
##########
@@ -182,7 +170,7 @@ void Collector::grab_thread() {
     PreprocessorMap prep_map;
 
     // The main loop.
-    while (!_stop) {
+    while (!_grab_thread->stop.load()) {

Review comment:
       所有的 stop.load() 可以封装一下。
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to