sunhs opened a new issue, #1758: URL: https://github.com/apache/incubator-brpc/issues/1758
https://github.com/apache/incubator-brpc/blob/c75d53a62c181db0aec300f41787c0c0786c69d0/src/brpc/circuit_breaker.cpp#L95 With `_max_error_percent` as an integer and less or equal to 100, it seems that the right hand side will always be either `_window_size` or `0`, which may causes a bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
