wwbmmm commented on code in PR #1768:
URL: https://github.com/apache/incubator-brpc/pull/1768#discussion_r891093386
##########
src/brpc/controller.h:
##########
@@ -554,6 +554,10 @@ friend void
policy::ProcessThriftRequest(InputMessageBase*);
// -1 means no deadline.
int64_t deadline_us() const { return _deadline_us; }
+ void add_auth_flags(uint32_t auth_flags) { _auth_flags = auth_flags; }
Review Comment:
这两个public方法可以不提供
不需要暴露给用户
在ControllerPrivateAccessor中直接访问私有成员即可
##########
src/brpc/details/controller_private_accessor.h:
##########
@@ -128,12 +128,12 @@ class ControllerPrivateAccessor {
void set_readable_progressive_attachment(ReadableProgressiveAttachment* s)
{ _cntl->_rpa.reset(s); }
- void add_with_auth() {
- _cntl->add_flag(Controller::FLAGS_REQUEST_WITH_AUTH);
+ void add_auth_flags(uint32_t auth_flags) {
Review Comment:
set_auth_flags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
