wwbmmm commented on code in PR #1790:
URL: https://github.com/apache/incubator-brpc/pull/1790#discussion_r894156200
##########
src/brpc/policy/thrift_protocol.cpp:
##########
@@ -161,8 +161,14 @@ bool ReadThriftStruct(const butil::IOBuf& body,
xfer += iprot.readStructEnd();
iprot.getTransport()->readEnd();
+ } catch (std::exception& e) {
+ LOG(WARNING) << "In read thrift struct, Catched exception::" <<
e.what();
+ } catch (std::string& e) {
Review Comment:
会有抛出std::string或const char*的情况吗？正常代码不应该这么做吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
