weingithub commented on issue #1772: URL: https://github.com/apache/incubator-brpc/issues/1772#issuecomment-1153439403
> > Acceptor::StartAccept中对_map_mutex的锁粒度太大了，如果在Socket::Create的期间释放锁，应该就不会死锁了 > > 按照这个代码注释: https://github.com/apache/incubator-brpc/blob/master/src/brpc/acceptor.cpp#L77 Socket::Create的期间还是需要加锁的，不能用这个方案。 > > 换了一个方案，可以试试这个PR #1791 @weingithub 谢谢你的帮助。我看代码修改里面，改了socket的create的失败逻辑。当前的死锁问题肯定是能够解决的。不过不确定会不会在其他地方引入新的问题？我看这个接口调用的地方挺多的。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
