wwbmmm commented on code in PR #1806: URL: https://github.com/apache/incubator-brpc/pull/1806#discussion_r902109456
########## src/brpc/details/naming_service_thread.h: ########## @@ -49,6 +49,7 @@ struct GetNamingServiceThreadOptions { bool succeed_without_server; bool log_succeed_without_server; ChannelSignature channel_signature; + std::string health_check_path; Review Comment: 哦,这里可以保留,但可以将health_check_path算到channel_signature里,这样SocketKey就不需要health_check_path了吧。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org