zyearn commented on code in PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r913263559
##########
src/brpc/socket_map.cpp:
##########
@@ -301,6 +301,7 @@ void SocketMap::RemoveInternal(const SocketMapKey& key,
_this_map_bvar = new bvar::PassiveStatus<std::string>(
butil::StringPiece(namebuf, len), PrintSocketMap, this);
}
+ s->DisableHealthCheck(); // disable health check
Review Comment:
这个深入代码细节以后的解释，如果在以后维护的时候（比如几个月后）或者换另外一个人看代码，很容易就忘记当时的实现了，这时候看到在没有HealthCheck的情况下，调用一个DisableHealthCheck会不知道为什么要这么做。这里可能需要一个直观上的解释
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
