zyearn commented on code in PR #1817:
URL: https://github.com/apache/incubator-brpc/pull/1817#discussion_r928087339
##########
src/brpc/socket.cpp:
##########
@@ -770,15 +773,22 @@ void Socket::Revive() {
}
int Socket::ReleaseAdditionalReference() {
- bool expect = false;
- // Use `relaxed' fence here since `Dereference' has `released' fence
- if (_recycle_flag.compare_exchange_strong(
- expect, true,
+ do {
+ AdditionalRefStatus expect = REF_USING;
+ if (_additional_ref_status.compare_exchange_strong(
+ expect,
+ REF_RECYLED,
butil::memory_order_relaxed,
butil::memory_order_relaxed)) {
- return Dereference();
- }
- return -1;
+ return Dereference();
+ }
+
+ if (expect == REF_REVIVING) { // sched_yield to wait until status is
not REF_REVIVING
+ sched_yield();
Review Comment:
考虑到目前这个情况出现的概率很低，用sched_yield应该可以
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
