hairet commented on PR #1031: URL: https://github.com/apache/incubator-brpc/pull/1031#issuecomment-1225167321
> 这个实现性能有很大优化吧。这个无脑 butex 唤醒有问题吧？理想状态下应该有个 flag 标识有没有真的有 bthread 在等待。 担心这个话，我的提交里改一行就可以了，butex_wake_all改成butex_wake即可。flag的话，我理解没有必要了，因为butex_wake自身有判空逻辑，开销也很低，加冗余逻辑就复杂了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
