hcoona commented on PR #1657: URL: https://github.com/apache/incubator-brpc/pull/1657#issuecomment-1231209259
@zyearn PTAL. I removed `bazel/third_party/glog/0001-improvement-copts.patch` & rename `bazel/third_party/glog/0002-mark-override.patch` to a more meaningful name `0001-mark-override-resolve-warning.patch`. If you think the example of building with old version of bazel for user is not necessary, I can remove it. The CI failure cannot be reproduced on my dev environment with GCC 9.4.0 & bazel 4.2.2 by running `CC=gcc CXX=g++ PURPOSE=compile-with-bazel-all-options sh build_in_travis_ci.sh`. I looked the source code, it shouldn't be such error. Please help to rerun the failed jobs if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
