Tuvie commented on code in PR #1999: URL: https://github.com/apache/incubator-brpc/pull/1999#discussion_r1024843646
########## src/brpc/rdma/rdma_helper.cpp: ########## @@ -99,37 +99,41 @@ static ibv_device** g_devices = NULL; static ibv_context* g_context = NULL; static SocketId g_async_socket; static ibv_pd* g_pd = NULL; -static std::vector<ibv_mr*>* g_mrs = NULL; +static std::vector<ibv_mr*>* g_mrs = NULL; // mr registered by brpc Review Comment: 其实针对这个问题，我有点想把IOBuf的结构改改。每一段user_data可能对应不同的lkey。如果这个lkey能存放在IOBuf的元数据里面，就不需要这个lookup了。你觉得如何？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
