fusying-hwang commented on issue #1918:
URL:
https://github.com/apache/incubator-brpc/issues/1918#issuecomment-1326138637
alright, it turns out to be my problem. They do support building as an
external lib from source. My humble bazel knowledge limits my ability to
appreciate this project.
custom_http_archive(
name = "brpc",
auto_bind = False,
repository_name = "com_github_brpc_brpc",
auto_strip = False,
strip_prefix = "incubator-brpc-1.3.0",
repo_mapping = {
"@com_github_google_leveldb": "@com_leveldb",
"@com_github_gflags_gflags": "@com_gflags",
"@com_github_madler_zlib": "@net_zlib_zlib_2",
"@openssl": "@com_openssl",
"@com_github_google_glog": "@com_glog",
},
)
native.bind(
name = "brpc",
actual = "@com_github_brpc_brpc//:brpc",
)
this is my solution, basically we already had some local names like leveldb,
gflags, ... all we need to do is using repo_mapping to map it.
One caveat, we statically linked openssl and in static linkage the order of
these two dependencies matter,
"@openssl//:crypto",
"@openssl//:ssl",
I do suggest the BRPC team switch these two lines so that I don't need to
patch it.
Hope that helps. And I think this issue can close now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
