wwbmmm commented on code in PR #2027:
URL: https://github.com/apache/incubator-brpc/pull/2027#discussion_r1037833869
##########
src/brpc/concurrency_limiter.h:
##########
@@ -33,7 +33,7 @@ class ConcurrencyLimiter {
// false when the concurrency reaches the upper limit, otherwise it
// returns true. Normally, when OnRequested returns false, you should
// return an ELIMIT error directly.
- virtual bool OnRequested(int current_concurrency) = 0;
+ virtual bool OnRequested(int current_concurrency, int32_t timeout_ms) = 0;
Review Comment:
> 我觉得Controller_是OK的，@wwbmmm 你的意见是怎么样的，如果没有异议，我改成Controller_。
可以看下我下面的评论，我认为这个地方暂时没必要传入timeout_ms，所以也没必要传入Controller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
