cdjingit commented on code in PR #2057:
URL: https://github.com/apache/incubator-brpc/pull/2057#discussion_r1058087993
##########
src/brpc/parallel_channel.h:
##########
@@ -94,10 +94,20 @@ struct SubCall {
class CallMapper : public SharedObject {
public:
virtual SubCall Map(int channel_index/*starting from 0*/,
+ int channel_count,
const google::protobuf::MethodDescriptor* method,
const google::protobuf::Message* request,
- google::protobuf::Message* response) = 0;
+ google::protobuf::Message* response) {
+ return Map(channel_index, method, request, response);
+ }
+
protected:
+ // TODO: Remove this backward compatibility method.
+ virtual SubCall Map(int channel_index/*starting from 0*/,
+ const google::protobuf::MethodDescriptor* method,
+ const google::protobuf::Message* request,
+ google::protobuf::Message* response) = 0;
Review Comment:
嗯，没必要是纯虚的了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
