Hi, On 2023/01/29 05:54:35 "Wang,Weibing" wrote: > +1 (binding) > > I have checked: > > [x] Download links are valid. > [x] Checksums and PGP signatures are valid. > [x] Source code distributions have correct names matching the current > release. > [x] LICENSE and NOTICE files are correct for each brpc repo. > [x] All files have license headers if necessary. > [x] No compiled archives bundled in source archive. > [x] Git tag and apache dist files have no diff. > > BTW, I suggest to put the new features (eg. RDMA support, mvariable > dump by prometheus, timeout concurrency limiter) at the beginning of > the release note.
OK, besides these, is there anything else that needs highlight? > > Best regards > Weibing > > On Sun, Jan 29, 2023 at 11:00 AM Shuai Liu <[email protected]> wrote: > > > > +1 (non-binding) > > > > I have checked: > > > > [x] Download links are valid. > > [x] Checksums and PGP signatures are valid. > > [x] Source code distributions have correct names matching the current > > release. > > [x] LICENSE and NOTICE files are correct for each brpc repo. > > [x] All files have license headers if necessary. > > [x] No compiled archives bundled in source archive. > > > > Best Regards, > > serverglen > > > > Best Regards, > > serverglen > > > > > > Xiaofeng <[email protected]> 于2023年1月24日周二 22:43写道： > > > > > > Hi Apache bRPC Community, > > > > > > A big Happy Chinese New Year to everyone. > > > > > > And this is a call for vote to release Apache bRPC version 1.4.0 > > > > > > [Release Note] > > > > > > - Add pull_request_template.md by @fansehep in #1952 > > > - Fix the linkage errors caused by duplicate symbols by @adonis0147 in > > > #1936 > > > - Fix "sched_to itself" error when building by Clang on Linux aarch64 > > > by @adonis0147 in #1950 > > > - Support to pack rpm for RHEL 9 distributions by @wasphin in #1955 > > > - Fix arena cleared early when parsing redis message by @dorothy00dd2 in > > > #1959 > > > - Enable brpc use rdma by @Tuvie in #1836 > > > - Reduce UT log output by @wwbmmm > > > - Migrate to GitHub workflow by @guodongxiaren and @zyearn > > > in #1899, #2008, #2015, #2018, #2023, #2030 > > > - Support mvariable dump by prometheus rpc service @ldak4747 in #1964 > > > - Avoid std::string copy @ml-haha in #1969 > > > - Add warning for rdma invoke when brpc is not compiled with rdma > > > by @Tuvie in #1967 > > > - Add rdma_performance bazel support by @372046933 in #1984 > > > - Add a flag to manage http body on error by @jamesge > > > - Fall back to libibverbs.so.1 by @372046933 in #1985 > > > - Fix HTTP invalid host issue for channel not inited by http(s) > > > by @thorneliu in #1973 > > > - Limit total streams oncomsume bytes in one socket by @chenbay in #1958 > > > - Fix warning message error by @leaf-potato in #1989 > > > - Refresh write timestamp when returning a Socket to its pool; > > > change default value of -idle_timeout_second to 30. by @jamesge > > > - Add gflag to disable sampler thread by @leaf-potato in #1990 > > > - Create bvar_c++.md under docs/en by @steven-66 in #1612 > > > - Include directly dependent header by @372046933 in #1993 > > > - Update warning message on iobuf.cpp by @wwbmmm > > > - Remove unnecessary semicolon by @guodongxiaren in #2004 > > > - Fix MacOS warning: bool literal returned from 'main' [-Wmain] by @zyearn > > > in #2020 > > > - Early return for IOBuf::append_user_data when size == 0 by @372046933 > > > in #2009 > > > - Make BUTIL_RAPIDJSON_NAMESPACE_BEGIN::GenericDocument's handler method > > > public to enable outside custom parser/writer by @old-bear in #2026 > > > - Fix some typos by @chenBright in #2028 > > > - Fix issue of ssl error code by @yyweii in #2019 > > > - Fix: domain name length by @wayslog in #1965 > > > - Allow IOBuf::append_user_data_with_meta to specify the lkey > > > of rdma memory region by @Tuvie in #2005 > > > - Only allow to convert root array to single repeated pb by @chenBright > > > in #2035 > > > - mbvar support delete_stats and has_stats interface by @serverglen in > > > #2041 > > > - Fix bug: QP cannot be put back to QP pool by @Tuvie in #2036 > > > - Add a description to the profile graph by @hongliuliao in #2007 > > > - Add bazel third_party support by @fansehep in #1996 > > > - Fix demangle core by @wwbmmm in #2037 > > > - FlatMap's value supports unique_ptr by @jamesge > > > - Optimize mbvar doc by @cdjingit in #2058 > > > - Delete deprecated logoff_ms gflag in example folder by @leaf-potato in > > > #2064 > > > - Optimize parallel channel request map method by @cdjingit in #2057 > > > - Fix rpc maybe error: "libbrpc.so: undefined symbol: pthread_mutex_lock" > > > by @co0l1ce in #2049 and roll-backed in #2076 > > > - Add timeout concurrency limiter by @yanglimingcn in #2027 > > > - Keep bthread TaskGroup abi compatible with NDEBUG macro by @wwbmmm in > > > #2047 > > > - Improve/add documents by @cuishuang, @tanzhongyi003, @lorinlee, @Huixxi, > > > @serverglen, @wwbmmm, @wasphin, @Tuvie, @0xflotus, @thinh2, > > > @leaf-potato, > > > @TousakaRin, @cdjingit, @chenBright, @freemandealer and @yanglimingcn > > > > > > > > > The release candidates: > > > https://dist.apache.org/repos/dist/dev/brpc/1.4.0 > > > > > > Git tag for the release: > > > https://github.com/apache/brpc/releases/tag/1.4.0 > > > > > > Release Commit ID: > > > https://github.com/apache/brpc/commit/cf2a22000584f30309e49e01e634128b193abb3e > > > > > > Keys to verify the Release Candidate: > > > https://dist.apache.org/repos/dist/dev/brpc/KEYS > > > > > > The vote will be open for at least 72 hours or until the necessary number > > > of > > > votes are reached. > > > > > > Please vote accordingly: > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > PMC vote is +1 binding, and all others are +1 non-binding. > > > > > > Checklist for reference: > > > [ ] Download links are valid. > > > [ ] Checksums and PGP signatures are correct. > > > [ ] Source code distributions have correct names matching the current > > > release. > > > [ ] LICENSE and NOTICE files are correct for each Apache bRPC repo. > > > [ ] All files have license headers if necessary. > > > [ ] All files have license headers if necessary. > > > [ ] No compiled archives are bundled in the source archive. > > > > > > Regards, > > > Xiaofeng > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
