cdjingit commented on code in PR #2106:
URL: https://github.com/apache/brpc/pull/2106#discussion_r1092723022
##########
src/brpc/policy/timeout_concurrency_limiter.cpp:
##########
@@ -67,8 +67,9 @@ bool TimeoutConcurrencyLimiter::OnRequested(int
current_concurrency,
if (cntl != nullptr && cntl->timeout_ms() != UNSET_MAGIC_NUM) {
timeout_ms = cntl->timeout_ms();
}
- return current_concurrency <= FLAGS_timeout_cl_max_concurrency &&
- _avg_latency_us < timeout_ms * 1000;
+ return current_concurrency == 1 ||
Review Comment:
```
return current_concurrency == 1 ||
(current_concurrency <= FLAGS_timeout_cl_max_concurrency &&
_avg_latency_us < timeout_ms * 1000); ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
