jamesge commented on code in PR #2123:
URL: https://github.com/apache/brpc/pull/2123#discussion_r1111454387
##########
src/brpc/periodic_naming_service.cpp:
##########
@@ -51,6 +51,10 @@ int PeriodicNamingService::RunNamingService(
actions->ResetServers(servers);
}
+ if (bthread_stopped(bthread_self())) {
Review Comment:
这里加下为什么要判stopped的注释吧，后续看到这段代码的人不会注意到这个pr的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
