wwbmmm commented on code in PR #2136:
URL: https://github.com/apache/brpc/pull/2136#discussion_r1116771544
##########
src/bvar/detail/sampler.cpp:
##########
@@ -108,6 +109,7 @@ class SamplerCollector : public bvar::Reducer<Sampler*,
CombineSampler> {
void run();
static void* sampling_thread(void* arg) {
+ butil::PlatformThread::SetName("brpc_sampling");
Review Comment:
In addition to the sampling thread, bvar also has a grab thread and two dump
threads. (see variable.cpp and collector.cpp) Can you also add names to them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
