wwbmmm commented on code in PR #2156:
URL: https://github.com/apache/brpc/pull/2156#discussion_r1131953069
##########
CMakeLists.txt:
##########
@@ -150,6 +150,11 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
endif()
endif()
+if(CMAKE_CXX_COMPILER_ID MATCHES "(AppleClang)|(Clang)" AND
CMAKE_SYSTEM_PROCESSOR MATCHES "(aarch64)|(arm64)")
Review Comment:
在这里判断的话只对cmake生效，我们还有make和bazel两种编译方式
是不是在头文件里进行判断，普适性更好一些
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
